cuda : fix GGML_CUDA_GRAPHS=OFF #15300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
github-actions
bot
added
Nvidia GPU
Collaborator
Author
|
Just the regular |
ggerganov
approved these changes
Aug 14, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
This should fix the issue, but wait for @JohannesGaessler to confirm this code is good. It might be cleaner to extract this CUDA graphs check outside the if in a temp variable.
JohannesGaessler
approved these changes
Aug 14, 2025
Collaborator
JohannesGaessler
left a comment
JohannesGaessler
left a comment
There was a problem hiding this comment.
I think this is still legible and fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15132 (comment)